Re: [PATCH v4 6/6] Add Propeller configuration for kernel build.
From: Masahiro Yamada
Date: Wed Oct 23 2024 - 03:29:38 EST
On Wed, Oct 23, 2024 at 4:25 PM Arnd Bergmann <arnd@xxxxxxxx> wrote:
>
> On Wed, Oct 23, 2024, at 07:06, Masahiro Yamada wrote:
> > On Tue, Oct 22, 2024 at 9:00 AM Rong Xu <xur@xxxxxxxxxx> wrote:
> >
> >> > > +===========
> >> > > +
> >> > > +Configure the kernel with::
> >> > > +
> >> > > + CONFIG_AUTOFDO_CLANG=y
> >> >
> >> >
> >> > This is automatically met due to "depends on AUTOFDO_CLANG".
> >>
> >> Agreed. But we will remove the dependency from PROPELlER_CLANG to AUTOFDO_CLANG.
> >> So we will keep the part.
> >
> >
> > You can replace "depends on AUTOFDO_CLANG" with
> > "imply AUTOFDO_CLANG" if it is sensible.
> >
> > Up to you.
>
> I don't think we should ever encourage the use of 'imply'
> because it is almost always used incorrectly.
If we are able to delete the 'imply' keyword, Kconfig would be a bit cleaner.
In most cases, it can be replaced with 'default'.
--
Best Regards
Masahiro Yamada