Re: [PATCH v4 net-next 03/13] dt-bindings: net: add bindings for NETC blocks control

From: Krzysztof Kozlowski
Date: Wed Oct 23 2024 - 04:56:16 EST


On 23/10/2024 10:18, Wei Fang wrote:
>>> +maintainers:
>>> + - Wei Fang <wei.fang@xxxxxxx>
>>> + - Clark Wang <xiaoning.wang@xxxxxxx>
>>> +
>>> +properties:
>>> + compatible:
>>> + enum:
>>> + - nxp,imx95-netc-blk-ctrl
>>> +
>>> + reg:
>>> + minItems: 2
>>> + maxItems: 3
>>
>> You have one device, why this is flexible? Device either has exactly 2
>> or exactly 3 IO spaces, not both depending on the context.
>>
>
> There are three register blocks, IERB and PRB are inside NETC IP, but NETCMIX
> is outside NETC. There are dependencies between these three blocks, so it is
> better to configure them in one driver. But for other platforms like S32, it does
> not have NETCMIX, so NETCMIX is optional.

But how s32 is related here? That's a different device.

Best regards,
Krzysztof