Re: [PATCH v17 02/16] function_graph: Replace fgraph_ret_regs with ftrace_regs

From: Google
Date: Wed Oct 23 2024 - 04:58:57 EST


On Mon, 21 Oct 2024 17:46:58 +0100
Will Deacon <will@xxxxxxxxxx> wrote:

> On Wed, Oct 16, 2024 at 09:58:09AM +0900, Masami Hiramatsu (Google) wrote:
> > From: Masami Hiramatsu (Google) <mhiramat@xxxxxxxxxx>
> >
> > Use ftrace_regs instead of fgraph_ret_regs for tracing return value
> > on function_graph tracer because of simplifying the callback interface.
> >
> > The CONFIG_HAVE_FUNCTION_GRAPH_RETVAL is also replaced by
> > CONFIG_HAVE_FUNCTION_GRAPH_FREGS.
> >
> > Signed-off-by: Masami Hiramatsu (Google) <mhiramat@xxxxxxxxxx>
> > Acked-by: Heiko Carstens <hca@xxxxxxxxxxxxx>
> > Cc: Catalin Marinas <catalin.marinas@xxxxxxx>
> > Cc: Will Deacon <will@xxxxxxxxxx>
> > Cc: Steven Rostedt <rostedt@xxxxxxxxxxx>
> > Cc: Mark Rutland <mark.rutland@xxxxxxx>
> > Cc: Huacai Chen <chenhuacai@xxxxxxxxxx>
> > Cc: WANG Xuerui <kernel@xxxxxxxxxx>
> > Cc: Paul Walmsley <paul.walmsley@xxxxxxxxxx>
> > Cc: Palmer Dabbelt <palmer@xxxxxxxxxxx>
> > Cc: Albert Ou <aou@xxxxxxxxxxxxxxxxx>
> > Cc: Vasily Gorbik <gor@xxxxxxxxxxxxx>
> > Cc: Alexander Gordeev <agordeev@xxxxxxxxxxxxx>
> > Cc: Heiko Carstens <hca@xxxxxxxxxxxxx>
> > Cc: Christian Borntraeger <borntraeger@xxxxxxxxxxxxx>
> > Cc: Sven Schnelle <svens@xxxxxxxxxxxxx>
> > Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> > Cc: Ingo Molnar <mingo@xxxxxxxxxx>
> > Cc: Borislav Petkov <bp@xxxxxxxxx>
> > Cc: Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>
> > Cc: x86@xxxxxxxxxx
> > Cc: "H. Peter Anvin" <hpa@xxxxxxxxx>
> > Cc: Mathieu Desnoyers <mathieu.desnoyers@xxxxxxxxxxxx>
> >
> > ---
> > Changes in v17:
> > - Fixes s390 return_to_handler according to Heiko's advice.
> > Changes in v16:
> > - According to the recent ftrace_regs.h change, override
> > ftrace_regs_get_frame_pointer() if needed.
> > - s390: keep stack_frame on stack, just replace fgraph_ret_regs
> > with ftrace_regs.
> > Changes in v8:
> > - Newly added.
> > ---
> > arch/arm64/Kconfig | 1 +
> > arch/arm64/include/asm/ftrace.h | 23 ++++++-----------------
> > arch/arm64/kernel/asm-offsets.c | 12 ------------
> > arch/arm64/kernel/entry-ftrace.S | 32 ++++++++++++++++++--------------
>
> For the arm64 parts:
>
> Acked-by: Will Deacon <will@xxxxxxxxxx>

Thank you!

>
> Will


--
Masami Hiramatsu (Google) <mhiramat@xxxxxxxxxx>