Re: [PATCH net-next v3] net: Implement fault injection forcing skb reallocation

[Breno Leitao]

On Sat, Oct 19, 2024 at 12:28:03AM +0900, Akinobu Mita wrote:
> 2024年10月14日(月) 22:50 Breno Leitao <leitao@xxxxxxxxxx>:
> > +static int __init skb_realloc_setup(char *str)
> > +{
> > +       return setup_fault_attr(&skb_realloc.attr, str);
> > +}
> > +__setup("skb_realloc=", skb_realloc_setup);
> 
> The documentation says "fail_net_force_skb_realloc=" boot option,
> but this code seems to add "skb_realloc=" boot option.
> 
> I don't have a strong opinion about the naming, but I feel like
> it's a bit long.  How about "fail_skb_realloc="?
> 
> The same goes for the debugfs directory name.
> 
> Reviewed-by: Akinobu Mita <akinobu.mita@xxxxxxxxx>

Thanks. I will update and spin a new version.