Re: [PATCH 1/3] blk-mq: add non_owner variant of start_freeze/unfreeze queue APIs

From: Christoph Hellwig
Date: Wed Oct 23 2024 - 08:19:48 EST


> +/*
> + * non_owner variant of blk_freeze_queue_start
> + *
> + * The queue needn't to be unfreeze in current task, and non-owner use is
> + * fragile and easy to cause race, please try your best to avoid it

Maybe say:

Unlike blk_freeze_queue_start, the queue doesn't need to be unfrozen
by the same task. This is fragile and should not be used if at all
possible.

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>