Re: [PATCH 3/3] block: model freeze & enter queue as lock for supporting lockdep

From: Christoph Hellwig
Date: Wed Oct 23 2024 - 08:23:05 EST


On Wed, Oct 23, 2024 at 05:54:35PM +0800, Ming Lei wrote:
> Recently we got several deadlock report[1][2][3] caused by blk_mq_freeze_queue
> and blk_enter_queue().

Please wrap your commit logs a 73 characters.

> For example, the following lockdep report can be triggered in the
> report[3].

And I think the commit log would be a lot more readable without the
long trace.

The code itself looks good:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>