[PATCH next] ASoC: codecs: fix error code in ntp8835_i2c_probe()
From: Harshit Mogalapalli
Date: Wed Oct 23 2024 - 10:58:24 EST
When reset_control_deassert() fails it returns valid error codes stored
in return, pass that to dev_err_probe() instead of
PTR_ERR(ntp8835->reset).
Fixes: dc9004ea273a ("ASoC: codecs: Add NeoFidelity NTP8835 codec")
Reported-by: kernel test robot <lkp@xxxxxxxxx>
Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Closes: https://lore.kernel.org/r/202409281054.DUTb5KxU-lkp@xxxxxxxxx/
Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@xxxxxxxxxx>
---
Based on static analysis, with smatch, only compile tested
---
sound/soc/codecs/ntp8835.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/ntp8835.c b/sound/soc/codecs/ntp8835.c
index 800bda6b49dd..796e1410496f 100644
--- a/sound/soc/codecs/ntp8835.c
+++ b/sound/soc/codecs/ntp8835.c
@@ -428,7 +428,7 @@ static int ntp8835_i2c_probe(struct i2c_client *i2c)
ret = reset_control_deassert(ntp8835->reset);
if (ret)
- return dev_err_probe(&i2c->dev, PTR_ERR(ntp8835->reset),
+ return dev_err_probe(&i2c->dev, ret,
"Failed to deassert reset\n");
dev_set_drvdata(&i2c->dev, ntp8835);
--
2.39.3