Re: [net-next,RESEND v6 2/2] net: wwan: t7xx: Add debug port

[Bjorn Helgaas]

On Mon, Oct 21, 2024 at 08:19:34PM +0800, Jinjian Song wrote:
> From: Jinjian Song <songjinjian@xxxxxxxxxxx>
> 
> Add support for userspace to switch on the debug port(ADB,MIPC).
>  - ADB port: /dev/wwan0adb0
>  - MIPC port: /dev/wwan0mipc0
> 
> Application can use ADB (Android Debg Bridge) port to implement
> functions (shell, pull, push ...) by ADB protocol commands.
> E.g., ADB commands:
>  - A_OPEN: OPEN(local-id, 0, "destination")
>  - A_WRTE: WRITE(local-id, remote-id, "data")
>  - A_OKEY: READY(local-id, remote-id, "")
>  - A_CLSE: CLOSE(local-id, remote-id, "")

s/Debg/Debug/

> Link: https://android.googlesource.com/platform/packages/modules/adb/+/refs/heads/main/README.md
> 
> Application can use MIPC (Modem Information Process Center) port
> to debug antenna tunner or noise profiling through this MTK modem
> diagnostic interface.

s/tunner/tuner/

> +++ b/Documentation/networking/device_drivers/wwan/t7xx.rst
> @@ -67,6 +67,28 @@ Write from userspace to set the device mode.
>  ::
>    $ echo fastboot_switching > /sys/bus/pci/devices/${bdf}/t7xx_mode
>  
> +t7xx_port_mode
> +--------------
> +The sysfs interface provides userspace with access to the port mode, this interface
> +supports read and write operations.

This file is not completely consistent, but 90% of it fits in 80
columns, so I would make your additions fit also.