Re: [PATCH 2/2] pinctrl: qcom: Add sm8750 pinctrl driver

[Melody Olvera]

On 10/22/2024 8:27 PM, Bjorn Andersson wrote:
> On Mon, Oct 21, 2024 at 04:04:14PM GMT, Melody Olvera wrote:
> > Add initial pinctrl driver to support pin configuration with pinctrl
> I think you should drop the word "initial", and perhaps insert "TLMM" in
> its place.

Ack.

> > framework for sm8750 SoC.
> [..]
> > diff --git a/drivers/pinctrl/qcom/pinctrl-sm8750.c b/drivers/pinctrl/qcom/pinctrl-sm8750.c
> [..]
> > +static const struct msm_pingroup sm8750_groups[] = {
> [..]
> > +	[215] = UFS_RESET(ufs_reset, 0xE2004, 0xE3000),
> It would be nice if these digits where lower case...

Ack.

> > +	[216] = SDC_QDSD_PINGROUP(sdc2_clk, 0xDB000, 14, 6),
> > +	[217] = SDC_QDSD_PINGROUP(sdc2_cmd, 0xDB000, 11, 3),
> > +	[218] = SDC_QDSD_PINGROUP(sdc2_data, 0xDB000, 9, 0),
> > +};
> > +
> [..]
> > +static const int sm8750_reserved_gpios[] = {
> > +	36, 37, 38, 39, 74, -1
> Any particular reason why these are not gpio-reserved-ranges in
> DeviceTree?

Not particularly; I wasn't sure whether or not to include in the initial 
dt patch.
Will add.

> > +};
> > +