Re: [PATCH v2 0/2] driver core: Avoid false-positive errors for intentionally skipped links

From: Nícolas F. R. A. Prado
Date: Wed Oct 23 2024 - 16:03:43 EST


On Tue, Oct 15, 2024 at 05:27:16PM -0400, Nícolas F. R. A. Prado wrote:
> This series gets rid of the false-positive errors printed when device
> links are intentionally skipped. Patch 1 commonizes the logic into a
> helper and patch 2 uses that to remove the error.
>
> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@xxxxxxxxxxxxx>
> ---
> Changes in v2:
> - Added patch 1 introducing the device_link_is_useless() helper and used
> that in patch 2
> - Link to v1: https://lore.kernel.org/r/20240624-fwdevlink-probed-no-err-v1-1-d1213cd354e2@xxxxxxxxxxxxx
>
> ---
> Nícolas F. R. A. Prado (2):
> driver core: Create device_link_is_useless() helper
> driver core: Don't log intentional skip of device link creation as error

NACK. It turned out these were real issues, for which fixes have now been
sent: https://lore.kernel.org/all/20241023191339.1491282-1-saravanak@xxxxxxxxxx
So let's keep the error log message around since it is useful to detect such
issues.

Thanks,
Nícolas