Re: [PATCH v5 12/40] x86/resctrl: Wrap resctrl_arch_find_domain() around rdt_find_domain()

From: Reinette Chatre
Date: Wed Oct 23 2024 - 17:16:35 EST


Hi James,

On 10/4/24 11:03 AM, James Morse wrote:
> rdt_find_domain() finds a domain given a resource and a cache-id.
> It's not quite right for the resctrl arch API as it also returns the
> position to insert a new domain, which is needed when bringing a
> domain online in the arch code.
>
> Wrap rdt_find_domain() in another function resctrl_arch_find_domain()
> in order to avoid the unnecessary argument outside the arch code.

I do not understand the motivation for this split. There does not seem to be
anything arch specific about rdt_find_domain(). Why does this need to
be arch API? Why can resctrl and all archs not use rdt_find_domain()?
Will MPAM organize domains differently somehow?

Reinette