Re: [PATCH 1/1 perf-tools] perf python: Fix up the build on architectures without HAVE_KVM_STAT_SUPPORT

[Arnaldo Carvalho de Melo]

On Wed, Oct 23, 2024 at 02:40:45PM -0700, Ian Rogers wrote:
> On Wed, Oct 23, 2024 at 2:05 PM Arnaldo Carvalho de Melo
> <acme@xxxxxxxxxx> wrote:
> >
> > Noticed while building on a raspbian arm 32-bit system.
> >
> > There was also this other case, fixed by adding a missing util/stat.h
> > with the prototypes:
> >
> >   /tmp/tmp.MbiSHoF3dj/perf-6.12.0-rc3/tools/perf/util/python.c:1396:6: error: no previous prototype for ‘perf_stat__set_no_csv_summary’ [-Werror=missing-prototypes]
> >    1396 | void perf_stat__set_no_csv_summary(int set __maybe_unused)
> >         |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> >   /tmp/tmp.MbiSHoF3dj/perf-6.12.0-rc3/tools/perf/util/python.c:1400:6: error: no previous prototype for ‘perf_stat__set_big_num’ [-Werror=missing-prototypes]
> >    1400 | void perf_stat__set_big_num(int set __maybe_unused)
> >         |      ^~~~~~~~~~~~~~~~~~~~~~
> >   cc1: all warnings being treated as errors
> >
> > In other architectures this must be building due to some lucky indirect
> > inclusion of that header.
> >
> > Fixes: 9dabf4003423c8d3 ("perf python: Switch module to linking libraries from building source")
> > Cc: Adrian Hunter <adrian.hunter@xxxxxxxxx>
> > Cc: Ian Rogers <irogers@xxxxxxxxxx>
> > Cc: Jiri Olsa <jolsa@xxxxxxxxxx>
> > Cc: Kan Liang <kan.liang@xxxxxxxxxxxxxxx>
> > Cc: Namhyung Kim <namhyung@xxxxxxxxxx>
> > Signed-off-by: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
> 
> So this will at least conflict with:
> https://lore.kernel.org/lkml/20241022173015.437550-6-irogers@xxxxxxxxxx/
> where the #ifdef-ed out functions are removed. Does that series fix
> the ARM32 issue? Could we land that?

I'd prefer to have what I posted for perf-tools, as it is smaller, and
to land the patch removing those functions on perf-tools-next.

I'll try to switch testing to a librecomputer board, the rpi3 is super
slow :-)

Thanks,

- Arnaldo