Re: [PATCH] mm/page_alloc: fix NUMA stats update for cpu-less nodes
From: Michal Hocko
Date: Wed Oct 23 2024 - 18:24:04 EST
On Wed 23-10-24 15:15:20, Dongjoo Seo wrote:
> Hi Andrew, Michal,
>
> Thanks for the feedback.
>
> The issue is that CPU-less nodes can lead to incorrect NUMA stats.
> For example, NUMA_HIT may incorrectly increase for CPU-less nodes
> because the current logic doesn't account for whether a node has CPUs.
Define incorrect
Current semantic doesn't really care about cpu less NUMA nodes because
current means whatever is required AFIU. This is certainly a long term
semantic. Why does this need to change and why it makes sense to
pre-existing users?
--
Michal Hocko
SUSE Labs