Re: [PATCH v5 38/40] fs/resctrl: Add boiler plate for external resctrl code
From: Reinette Chatre
Date: Wed Oct 23 2024 - 20:08:46 EST
Hi James,
On 10/4/24 11:03 AM, James Morse wrote:
...
> +++ b/fs/resctrl/Kconfig
> @@ -0,0 +1,37 @@
> +config RESCTRL_FS
> + bool "CPU Resource Control Filesystem (resctrl)"
> + depends on ARCH_HAS_CPU_RESCTRL
> + select KERNFS
> + select PROC_CPU_RESCTRL if PROC_FS
> + help
> + Some architectures provide hardware facilities to group tasks and
> + monitor and control their usage of memory system resources such as
> + caches and memory bandwidth. Examples of such facilities include
> + Intel's Resource Director Technology (Intel(R) RDT) and AMD's
> + Platform Quality of Service (AMD QoS).
> +
> + If your system has the necessary support and you want to be able to
> + assign tasks to groups and manipulate the associated resource
> + monitors and controls from userspace, say Y here to get a mountable
> + 'resctrl' filesystem that lets you do just that.
> +
> + If nothing mounts or prods the 'resctrl' filesystem, resource
> + controls and monitors are left in a quiescent, permissive state.
> +
> + On architectures where this can be disabled independently, it is
> + safe to say N.
> +
> + See <file:Documentation/arch/x86/resctrl.rst> for more information.
> +
> +config RESCTRL_FS_PSEUDO_LOCK
> + bool
> + help
> + Software mechanism to pin data in a cache portion using
> + micro-architecture specific knowledge.
> +
There now seems to be two copies of this ... patch #23 added this exact same
"config RESCTRL_FS_PSEUDO_LOCK" snippet to arch/x86/Kconfig
> +config RESCTRL_RMID_DEPENDS_ON_CLOSID
> + bool
> + help
> + Enable by the architecture when the RMID values depend on the CLOSID.
"Enable by" -> "Enabled by"?
> + This causes the closid allocator to search for CLOSID with clean
> + RMID.
Reinette