Re: [PATCH v5 40/40] x86/resctrl: Add python script to move resctrl code to /fs/resctrl

[Reinette Chatre]

Hi James,

On 10/8/24 4:08 PM, Tony Luck wrote:
> On Fri, Oct 04, 2024 at 06:03:47PM +0000, James Morse wrote:
>> +functions_to_move = [
>> +	# common
>> +	"pr_fmt",
>> +
>> +	# ctrlmon.c
>> +	"rdt_parse_data",
>> +	"(ctrlval_parser_t)",
>> +	"bw_validate",
>> +	"parse_bw",
>> +	"cbm_validate",
>> +	"parse_cbm",
>> +	"get_parser",
>> +	"parse_line",
>> +	"rdtgroup_parse_resource",
>> +	"rdtgroup_schemata_write",
>> +	"show_doms",
>> +	"rdtgroup_schemata_show",
>> +	"smp_mon_event_count",
>> +	"mon_event_read",
>> +	"rdtgroup_mondata_show",
>> +
>> +	# internal.h
>> +	"MBM_OVERFLOW_INTERVAL",
>> +	"CQM_LIMBOCHECK_INTERVAL",
>> +	"cpumask_any_housekeeping",
>> +	"rdt_fs_context",
>> +	"rdt_fc2context",
>> +	"mon_evt",
>> +	"mon_data_bits",
>> +	"rmid_read",
>> +	"resctrl_schema_all",
>> +	"resctrl_mounted",
>> +	"rdt_group_type",
>> +	"rdtgrp_mode",
>> +	"mongroup",
>> +	"rdtgroup",
>> +	"RFTYPE_FLAGS_CPUS_LIST",
> 
> Something goes wrong with moving the RFTYPE_* defines. A new copy
> shows up in fs/resctrl/internal.h but the old copy isn't removed from
> arch/x86/kernel/cpu/resctrl/internal.h
> 
There seems to be a few more duplicates: RMID_VAL_ERROR, RMID_VAL_UNAVAIL,
MBM_CNTR_WIDTH_OFFSET_MAX, RDT_DELETED.

Also please check the trace files after the move and related CFLAGS.
arch/x86/kernel/cpu/resctrl/monitor_trace.h is just empty and the
arch/x86/kernel/cpu/resctrl/Makefile still has the "CFLAGS_monitor.o = -I$(src)"
Also please check fs/resctrl/pseudo_lock_trace.h

Reinette