Re: [PATCH sched_ext/for-6.13 2/2] sched_ext: Replace set_arg_maybe_null() with __nullable CFI stub tags
From: Alexei Starovoitov
Date: Wed Oct 23 2024 - 21:05:18 EST
On Wed, Oct 23, 2024 at 5:55 PM Tejun Heo <tj@xxxxxxxxxx> wrote:
>
> ops.dispatch() and ops.yield() may be fed a NULL task_struct pointer.
> set_arg_maybe_null() is used to tell the verifier that they should be NULL
> checked before being dereferenced. BPF now has an a lot prettier way to
> express this - tagging arguments in CFI stubs with __nullable. Replace
> set_arg_maybe_null() with __nullable CFI stub tags.
>
> Signed-off-by: Tejun Heo <tj@xxxxxxxxxx>
> Cc: Martin KaFai Lau <martin.lau@xxxxxxxxxx>
> Cc: Alexei Starovoitov <ast@xxxxxxxxxx>
for this and 1st patch:
Acked-by: Alexei Starovoitov <ast@xxxxxxxxxx>
Nice cleanup!