Re: [PATCH v2 2/2] ipmi: ssif_bmc: add GPIO-based alert mechanism

[Quan Nguyen]

On 22/10/2024 08:20, Potin Lai wrote:
> From: Cosmo Chou <chou.cosmo@xxxxxxxxx>
>
> Implement GPIO-based alert mechanism in the SSIF BMC driver to notify
> the host when a response is ready.
>
> This improves host-BMC communication efficiency by providing immediate
> notification, potentially reducing host polling overhead.
>
> Signed-off-by: Cosmo Chou <chou.cosmo@xxxxxxxxx>
> ---
>   drivers/char/ipmi/ssif_bmc.c | 15 +++++++++++++++
>   1 file changed, 15 insertions(+)

Thanks for adding feature to this driver, the code looks good to me.

Reviewed-by: Quan Nguyen <quan@xxxxxxxxxxxxxxxxxxxxxx>

I'm just have a bit of curious on how the ipmi_ssif in host side to work 
with this mechanism? Will there be patches for ipmi_ssif to use this 
feature followed?

Thanks and Best regards,
- Quan