Re: ODP: [PATCH v5 1/2] dt-bindings: i2c: pca954x: Add timeout reset property
From: Krzysztof Kozlowski
Date: Thu Oct 24 2024 - 03:10:09 EST
On 24/10/2024 09:05, Wojciech Siudy (Nokia) wrote:
> Hello,
>
>> This is reset of the I2C devices (children), not the controller, right?
> Right, the mux is child device.
Not sure to which part I replied to. I have DT 200 emails in inbox per
day, I respond to less but still more than I can track. Keep some context.
I suspect you are adding reset for some other device, not for the one here.
>
>> switch to reset controller framework
> Please note that I left the function pca954x_reset_deassert() unchanged,
> just moved it up and implemented two corresponding ones.
> Do you mean that we should get rid of gpiod_set_value_cansleep(),
> because the reset controller will handle it? I can agree but this is topic
> for another submission since there we change when the reset is done,
> not the way we achieve that.
No, I meant I suspect you place property in inappropriate binding to
avoid shared GPIO problem.
Best regards,
Krzysztof