Re: [patch V5 05/26] posix-timers: Drop signal if timer has been deleted or reprogrammed
From: Thomas Gleixner
Date: Thu Oct 24 2024 - 04:40:18 EST
On Mon, Oct 21 2024 at 14:29, Frederic Weisbecker wrote:
> Le Tue, Oct 01, 2024 at 10:42:06AM +0200, Thomas Gleixner a écrit :
>> No point in delivering a signal from the past. POSIX does not specify the
>> behaviour here:
>>
>> - "The effect of disarming or resetting a timer with pending expiration
>> notifications is unspecified."
>>
>> - "The disposition of pending signals for the deleted timer is unspecified."
>>
>> In both cases it is reasonable to expect that pending signals are
>> discarded. Especially in the reprogramming case it does not make sense to
>> account for previous overruns or to deliver a signal for a timer which has
>> been disarmed.
>
> The change below indeed checks if the timer has been deleted but not if
> it has been reprogrammed/disarmed/reset.
>
> Or am I missing something?
No. You are right. This is a change log left over from a previous
version. This rearm/disarm part is handled later in the series.
Thanks,
tglx