Re: linus-next: improving functional testing for to-be-merged pull requests
From: Steven Rostedt
Date: Thu Oct 24 2024 - 05:21:55 EST
On Thu, 24 Oct 2024 09:01:15 +0200
Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:
> On Thu, Oct 24, 2024 at 5:59 AM Michael Ellerman <mpe@xxxxxxxxxxxxxx> wrote:
> > Several thousand build tests, across pretty much every architecture.
> >
> > And a few hundred boot tests, lots virtualised, but some on real HW.
> >
> > A single character typo in an #ifdef your testing doesn't cover can
> > break the build for lots of people ...
>
> Or a missing "static" for a dummy function.
> Or a plain 64-bit division.
> Or ...
Note, my fixes code seldom adds dummy functions. I like to try to keep
them as small as possible. That's not always the case, so maybe I could
push it. But it will change my workflow quite a bit or burden Stephen
with broken branches.
I'm still not convinced it's worth it.
We are not talking about new development code. We are talking about bug
fixes for code that is in Linus's tree. The zero day bot and my tests
appear to find most issues. Bugs that happened on my fixes patches are
usually other use cases. For instance, cpu hotplug while tracing from
rtla. That's not coverage I get from linux-next.
-- Steve