Re: [PATCH] kvm: selftest: fix noop test in guest_memfd_test.c

From: Gowans, James
Date: Thu Oct 24 2024 - 06:19:39 EST


On Thu, 2024-10-24 at 10:59 +0100, Patrick Roy wrote:
> The loop in test_create_guest_memfd_invalid that is supposed to test
> that nothing is accepted as a valid flag to KVM_CREATE_GUEST_MEMFD was
> initializing `flag` as 0 instead of BIT(0). This caused the loop to
> immediately exit instead of iterating over BIT(0), BIT(1), ... .
>
> Fixes: 8a89efd43423 ("KVM: selftests: Add basic selftest for guest_memfd()")
> Signed-off-by: Patrick Roy <roypat@xxxxxxxxxxxx>
> ---
> tools/testing/selftests/kvm/guest_memfd_test.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/kvm/guest_memfd_test.c b/tools/testing/selftests/kvm/guest_memfd_test.c
> index ba0c8e9960358..ce687f8d248fc 100644
> --- a/tools/testing/selftests/kvm/guest_memfd_test.c
> +++ b/tools/testing/selftests/kvm/guest_memfd_test.c
> @@ -134,7 +134,7 @@ static void test_create_guest_memfd_invalid(struct kvm_vm *vm)
> size);
> }
>
> - for (flag = 0; flag; flag <<= 1) {
> + for (flag = BIT(0); flag; flag <<= 1) {
> fd = __vm_create_guest_memfd(vm, page_size, flag);
> TEST_ASSERT(fd == -1 && errno == EINVAL,
> "guest_memfd() with flag '0x%lx' should fail with EINVAL",

Reviewed-by: James Gowans <jgowans@xxxxxxxxxx>