Re: [PATCH 1/3] dt-bindings: mailbox: mediatek: Add apu-mailbox document

From: AngeloGioacchino Del Regno
Date: Thu Oct 24 2024 - 07:09:25 EST


Il 24/10/24 11:25, Karl.Li ha scritto:
From: Karl Li <karl.li@xxxxxxxxxxxx>

Add apu-mailbox dt-binding document.

Signed-off-by: Karl Li <karl.li@xxxxxxxxxxxx>
---
.../mailbox/mediatek,apu-mailbox.yaml | 55 +++++++++++++++++++
1 file changed, 55 insertions(+)
create mode 100644 Documentation/devicetree/bindings/mailbox/mediatek,apu-mailbox.yaml

diff --git a/Documentation/devicetree/bindings/mailbox/mediatek,apu-mailbox.yaml b/Documentation/devicetree/bindings/mailbox/mediatek,apu-mailbox.yaml
new file mode 100644
index 000000000000..cb4530799bef
--- /dev/null
+++ b/Documentation/devicetree/bindings/mailbox/mediatek,apu-mailbox.yaml
@@ -0,0 +1,55 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/mailbox/mediatek,apu-mailbox.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: MediaTek APU mailbox
+
+maintainers:
+ - Karl Li <Karl.Li@xxxxxxxxxxxx>
+
+description:
+ The MediaTek APU-Mailbox facilitates communication with the
+ APU microcontroller. Within the MediaTek APU subsystem, a
+ message passing mechanism is built on top of the mailbox system.
+ The mailbox only has limited space for each message. The firmware
+ expects the message header from the mailbox, while the message body
+ is passed through some fixed shared memory.
+
+properties:
+ compatible:
+ enum:
+ - mediatek,mt8188-apu-mailbox
+ - mediatek,mt8196-apu-mailbox

In addition to Krzysztof's review......

oneOf:
- const: mediatek,mt8188-apu-mailbox
- items:
- enum:
- mediatek,mt8195-apu-mailbox
- mediatek,mt8196-apu-mailbox
- const: mediatek,mt8188-apu-mailbox

should be like that - I haven't checked if this gives any warnings, but anyway
you got the point, I think.

Regards,
Angelo