Re: [patch V5 07/26] posix-timers: Add proper state tracking
From: Frederic Weisbecker
Date: Thu Oct 24 2024 - 08:10:53 EST
Le Thu, Oct 24, 2024 at 10:45:24AM +0200, Thomas Gleixner a écrit :
> On Mon, Oct 21 2024 at 15:19, Frederic Weisbecker wrote:
>
> > Le Tue, Oct 01, 2024 at 10:42:09AM +0200, Thomas Gleixner a écrit :
> >> From: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> >>
> >> Right now the state tracking is done by two struct members:
> >>
> >> - it_active:
> >> A boolean which tracks armed/disarmed state
> >>
> >> - it_signal_seq:
> >> A sequence counter which is used to invalidate settings
> >> and prevent rearming
> >>
> >> Replace it_active with it_status and keep properly track about the states
> >> in one place.
> >>
> >> This allows to reuse it_signal_seq to track reprogramming, disarm and
> >
> > Did you mean it_status here?
>
> No. it_signal_seq is used to validate whether a queued, but not yet
> delivered signal, is valid or not. The sequence is stored in the signal
> when the signal is queued and compared to the sequence on delivery.
Yeah I missed the following patches that increment it_signal_seq on delete
and reset. Makes more sense now.
Thanks!
>
> Thanks,
>
> tglx