Re: [PATCH RFC 5/6] md/raid1: Handle bio_split() errors

[John Garry]

On 24/10/2024 04:08, Yu Kuai wrote:
> > I could just have this pattern:

Hi Kuai,

> > bio->bi_status = errno_to_blk_status(err);
> > set_bit(R1BIO_Uptodate, &r1_bio->state);
> > raid_end_bio_io(r1_bio);
> I can live with this. 🙂
>
> > Is there a neater way to do this?
>
> Perhaps add a new filed 'status' in r1bio? And initialize it to
> BLK_STS_IOERR;
>
> Then replace:
> set_bit(R1BIO_Uptodate, &r1_bio->state);
> to:
> r1_bio->status = BLK_STS_OK;

So are you saying that R1BIO_Uptodate could be dropped then?

> and change call_bio_endio:
> bio->bi_status = r1_bio->status;
>
> finially here:
> r1_bio->status = errno_to_blk_status(err);
> raid_end_bio_io(r1_bio);

Why not just set bio->bi_status directly?

Cheers,
John