Re: [PATCH v4 10/12] arm64: dts: renesas: rzg3s-smarc-som: Enable VBATTB

[Geert Uytterhoeven]

Hi Claudiu,

On Sat, Oct 19, 2024 at 10:48 AM Claudiu <claudiu.beznea@xxxxxxxxx> wrote:
> From: Claudiu Beznea <claudiu.beznea.uj@xxxxxxxxxxxxxx>
>
> Enable the VBATTB controller. It provides the clock for RTC.
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@xxxxxxxxxxxxxx>
> ---
>
> Changes in v4:
> - added assigned-clocks, assigned-clock-parents properties
> - set vbattb_xtal status = "okay"
> - collected tags

Thanks for the update!

> --- a/arch/arm64/boot/dts/renesas/rzg3s-smarc-som.dtsi
> +++ b/arch/arm64/boot/dts/renesas/rzg3s-smarc-som.dtsi
> @@ -346,6 +347,18 @@ mux {
>         };
>  };
>
> +&vbattb {
> +       assigned-clocks = <&vbattb VBATTB_MUX>;
> +       assigned-clock-parents = <&vbattb VBATTB_XC>;
> +       quartz-load-femtofarads = <12500>;
> +       status = "okay";
> +};
> +
> +&vbattb_xtal {
> +       clock-frequency = <32768>;
> +       status = "okay";

With status not disabled in r9a08g045.dtsi, this line should not be needed.

> +};
> +
>  &wdt0 {
>         timeout-sec = <60>;
>         status = "okay";

Gr{oetje,eeting}s,

                        Geert


--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds