Re: [PATCH net-next 2/7] net: hibmcge: Add debugfs supported in this module

From: Jijie Shao
Date: Thu Oct 24 2024 - 10:33:04 EST



on 2024/10/24 22:21, Andrew Lunn wrote:
On Thu, Oct 24, 2024 at 10:06:14PM +0800, Jijie Shao wrote:
on 2024/10/24 20:05, Andrew Lunn wrote:
+ seq_printf(s, "mdio frequency: %u\n", specs->mdio_frequency);
Is this interesting? Are you clocking it greater than 2.5MHz?
MDIO controller supports 1MHz, 2.5MHz, 12.5MHz, and 25MHz
Of course, we chose and tested 2.5M in actual work, but this can be modified.
How? What API are you using it allow it to be modified? Why cannot you
get the value using the same API?
This frequency cannot be modified dynamically.
There are some specification registers that store some initialization configuration parameters
written by the BMC, such as the default MAC address and hardware FIFO size and mdio frequency.

When the device is in prob, the driver reads the related configuration information and
initializes the device based on the configuration.
Does the BMC have an API to set these values? And show these values?

Andrew

Currently, there are no other API except devmem.

But this is not important.
According to the discussion in patch "[PATCH net-next 4/7] net: hibmcge: Add register dump supported in this module",
this debugfs file will be deleted. I will put these informations in register dump by ethtool -d.

Thanks