Re: [PATCH] rust: irq: add support for request_irq()

From: Miguel Ojeda
Date: Thu Oct 24 2024 - 11:06:16 EST


Hi Daniel,

A couple procedural things on your latest patches (no need to send new
versions right away).

On Thu, Oct 24, 2024 at 4:20 PM Daniel Almeida
<daniel.almeida@xxxxxxxxxxxxx> wrote:
>
> Both regular and threaded versions are supported.

I am not sure if the commit message was truncated, but it should
explain why the change is done and what is being changed. For
instance, it should mention who will need this upstream. Please see
other similar patches/series we have, e.g. one of the latest ones in Lore:

https://lore.kernel.org/rust-for-linux/20241022213221.2383-1-dakr@xxxxxxxxxx/

> base-commit: 33c255312660653cf54f8019896b5dca28e3c580

Please try this one on top of `rust-next` -- you will get new Clippy
warnings about missing safety sections & comments.

Thanks!

Cheers,
Miguel