Re: [PATCH v2] rust: kernel: add support for bits/genmask macros

From: Daniel Almeida
Date: Thu Oct 24 2024 - 11:07:31 EST


Sorry, I switched to b4 yesterday and I am still getting used to the workflow with it.


> On 24 Oct 2024, at 11:17, Daniel Almeida <daniel.almeida@xxxxxxxxxxxxx> wrote:
>
> These macros are converted from their kernel equivalent.
>
> ---
> - Added ticks around `BIT`, and `h >=l` (Thanks, Benno).
> - Decided to keep the arguments as `expr`, as I see no issues with that
> - Added a proper example, with an assert_eq!() (Thanks, Benno)
> - Fixed the condition h <= l, which should be h >= l.
> - Checked that the assert for the condition above is described in the
> docs.
>
> Signed-off-by: Daniel Almeida <daniel.almeida@xxxxxxxxxxxxx>


This should read “Changes from v1”