Re: [PATCH v7 2/8] dt-bindings: iio: dac: adi-axi-dac: add ad3552r axi variant
From: Conor Dooley
Date: Thu Oct 24 2024 - 12:45:28 EST
On Thu, Oct 24, 2024 at 09:43:02AM -0500, David Lechner wrote:
> >>>
> >> thanks, could you maybe have a look if it's ok now ?
> >> (maxItems not needed for a const list)
> >>
> >> clocks:
> >> minItems: 1
> >> maxItems: 2
> >>
> >> clock-names:
> >> items:
> >> - const: s_axi_aclk
> >> - const: dac_clk
> >> minItems: 1
> >>
> >> '#io-backend-cells':
> >> const: 0
> >>
> >> required:
> >> - compatible
> >> - dmas
> >> - reg
> >> - clocks
> >>
> >> allOf:
> >> - if:
> >> properties:
> >> compatible:
> >> contains:
> >> const: adi,axi-ad3552r
> >> then:
> >> $ref: /schemas/spi/spi-controller.yaml#
> >> properties:
> >> clocks:
> >> minItems: 2
> >> clock-names:
> >> minItems: 2
>
>
> For this one, I think we also need:
>
> required:
> - clock-names
Ye, Angelo had that in the version posted in response to the driver
patch.
This looks ~correct.
>
> >> else:
> >> properties:
> >> clocks:
> >> maxItems: 1
> >> clock-names:
> >> maxItems: 1
> >
> > I guess in this case it could even be clock-names: false. One does not make much
> > sense.
And since it is not mandatory, doubly useless.
Attachment:
signature.asc
Description: PGP signature