RE: [PATCH v8 08/25] x86/resctrl: Introduce interface to display number of monitoring counters

From: Luck, Tony
Date: Thu Oct 24 2024 - 13:37:49 EST


> >> Since you seem to want to keep the flexibility for a possible future
> >> where per-domain is needed. The "available_mbm_cntrs" file
> >> suggested in another thread would need to list available counters
> >> on each domain to avoid ABI problems should that future arrive.
> >>
> >> $ cat num_mbm_counters
> >> 32
> >>
> >> $ cat available_mbm_cntrs
> >> 0=12;1=9
> >
> > Good point.
> >
>
> Working on this now. Wanted to confirm if we really need domain specific
> information?
>
> To me, it does not seem necessary for the user. User cannot make any
> decisions based on this information.
>
> All user wants to know is if there are global counters available.
>
> $ cat num_mbm_counters
> 32
>
> $ cat available_mbm_cntrs
> 15

This approach paints resctrl into an ABI corner where it can't later
update resctrl to track counters per-domain. Maybe you'll never want to do that,
but some other architecture might want to have that flexibility.

-Tony