Re: [RFC PATCH v1 10/10] net: qrtr: mhi: Report endpoint id in sysfs

From: Denis Kenzior
Date: Thu Oct 24 2024 - 14:06:49 EST


Hi Chris,

@@ -72,6 +72,16 @@ static int qcom_mhi_qrtr_send(struct qrtr_endpoint *ep, struct sk_buff *skb)
      return rc;
  }
+static ssize_t endpoint_show(struct device *dev,
+                 struct device_attribute *attr, char *buf)
+{
+    struct qrtr_mhi_dev *qdev = dev_get_drvdata(dev);
+
+    return sprintf(buf, "%d\n", qdev->ep.id);

%u might be more appropriate because the endpoint id is stored as a u32

Nice catch. I'll fix it for the next version.

Regards,
-Denis