Re: [net-next v3] net: ftgmac100: refactor getting phy device handle

From: Andrew Lunn
Date: Thu Oct 24 2024 - 15:42:33 EST


On Tue, Oct 22, 2024 at 04:42:14PM +0800, Jacky Chou wrote:
> Consolidate the handling of dedicated PHY and fixed-link phy by taking
> advantage of logic in of_phy_get_and_connect() which handles both of
> these cases, rather than open coding the same logic in ftgmac100_probe().
>
> Signed-off-by: Jacky Chou <jacky_chou@xxxxxxxxxxxxxx>
> ---
> v2:
> - enable mac asym pause support for fixed-link PHY
> - remove fixes information
> v3:
> - Adjust the commit message

It takes a bit of effort to see it is correct, but it looks O.K. to
me.

Reviewed-by: Andrew Lunn <andrew@xxxxxxx>

Andrew