Re: [PATCH v7 2/3] modpost: Produce extended MODVERSIONS information

From: Sami Tolvanen
Date: Thu Oct 24 2024 - 19:02:07 EST


On Wed, Oct 23, 2024 at 02:31:29AM +0000, Matthew Maurer wrote:
> Generate both the existing modversions format and the new extended one
> when running modpost. Presence of this metadata in the final .ko is
> guarded by CONFIG_EXTENDED_MODVERSIONS.
>
> We no longer generate an error on long symbols in modpost if
> CONFIG_EXTENDED_MODVERSIONS is set, as they can now be appropriately
> encoded in the extended section. These symbols will be skipped in the
> previous encoding. An error will still be generated if
> CONFIG_EXTENDED_MODVERSIONS is not set.
>
> Signed-off-by: Matthew Maurer <mmaurer@xxxxxxxxxx>

Thanks for fixing this, LGTM.

Reviewed-by: Sami Tolvanen <samitolvanen@xxxxxxxxxx>

Sami