Re: [PATCH 4/4] net: stmmac: Add glue layer for Sophgo SG2044 SoC

From: Inochi Amaoto
Date: Thu Oct 24 2024 - 21:41:21 EST


On Thu, Oct 24, 2024 at 05:37:03PM +0200, Uwe Kleine-König wrote:
> Hello,
>
> On Mon, Oct 21, 2024 at 06:36:17PM +0800, Inochi Amaoto wrote:
> > +static struct platform_driver sophgo_dwmac_driver = {
> > + .probe = sophgo_dwmac_probe,
> > + .remove_new = stmmac_pltfr_remove,
> > + .driver = {
> > + .name = "sophgo-dwmac",
> > + .pm = &stmmac_pltfr_pm_ops,
> > + .of_match_table = sophgo_dwmac_match,
> > + },
> > +};
>
> After commit 0edb555a65d1 ("platform: Make platform_driver::remove()
> return void") .remove() is (again) the right callback to implement for
> platform drivers. Please just drop "_new".
>
> Best regards
> Uwe


Thanks, I will fix it.

Regards,
Inochi