Re: [PATCH v2 3/4] dma-mapping: Use trace_dma_alloc for dma_alloc* instead of using trace_dma_map

From: Steven Rostedt
Date: Thu Oct 24 2024 - 22:20:12 EST


On Fri, 18 Oct 2024 11:00:36 -0400
Sean Anderson <sean.anderson@xxxxxxxxx> wrote:

> + TP_printk("%s dir=%s dma_addr=%llx size=%zu phys_addrs=%s flags=%s attrs=%s",
> + __get_str(device),
> + decode_dma_data_direction(__entry->dir),
> + __entry->dma_addr,
> + __entry->size,
> + __print_array(__get_dynamic_array(phys_addrs),
> + __get_dynamic_array_len(phys_addrs) /
> + sizeof(u64), sizeof(u64)),
> + show_gfp_flags(__entry->flags),
> + decode_dma_attrs(__entry->attrs))

From a tracing perspective, everything in the patch set looks good.
Just a heads up that the above __print_array() should be changed after
6.13 is out to use __print_dynamic_array().

https://lore.kernel.org/linux-trace-kernel/20241022194158.110073-3-avadhut.naik@xxxxxxx/

For the series:

Reviewed-by: Steven Rostedt (Google) <rostedt@xxxxxxxxxxx>

-- Steve