Re: [PATCH v3] [net-next] igb: Fix 2 typos in comments in igb_main.c

From: Johnny Park
Date: Fri Oct 25 2024 - 01:06:33 EST


On Thu, Oct 24, 2024 at 10:41:25AM +0200, Przemek Kitszel wrote:
> On 10/24/24 07:45, Johnny Park wrote:
> you should collect Reviewed-by tags, as the one from Simon on v2.
Sorry, I wasn't aware of that rule. For future pathces I'll include reviewed/acked tags.

> for future Intel Ethernet drivers series, please target them to IWL
> (net-next in the Subject becomes iwl-next)
Sorry again, from the other patchworks https://patchwork.ozlabs.org/project/intel-wired-lan/list/ I should have noticed that pattern.
> > ring = q_vector->ring;
> > - /* intialize ITR */
> > + /* initialize ITR */
> > if (rxr_count) {
> > /* rx or rx/tx vector */
>
> Would be great to have capitalization errors fixed too, Rx, Tx, VF, not
> necessarily in this patch.
That sounds like a good idea, perhaps fixing those will be my next patch.

> to reduce traffic, I'm fine with this, to go via any tree:
> Acked-by: Przemek Kitszel <przemyslaw.kitszel@xxxxxxxxx>
Thank you for the review!

Regards,
Johnny