Re: [PATCHv2 12/23] ARM: socfpga: dts: add a10 clock binding yaml

From: Lothar Rubusch
Date: Fri Oct 25 2024 - 03:00:37 EST


On Thu, Oct 24, 2024 at 8:24 AM Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:
>
> On 24/10/2024 08:10, Lothar Rubusch wrote:
> > On Mon, Oct 21, 2024 at 9:05 AM Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:
> >>
[...]
> >>> diff --git a/Documentation/devicetree/bindings/clock/altr,socfpga-a10.yaml b/Documentation/devicetree/bindings/clock/altr,socfpga-a10.yaml
> >>> new file mode 100644
> >>> index 000000000..795826f53
> >>> --- /dev/null
> >>> +++ b/Documentation/devicetree/bindings/clock/altr,socfpga-a10.yaml
> >>> @@ -0,0 +1,107 @@
> >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> >>> +%YAML 1.2
[...]
> What corresponding txt file? You are adding new binding. Are you saying
> you duplicated bindings instead of doing conversion?
>
> git log -p -- Documentation/devicetree | grep -i convert

Please, try the following:
$ find ./Documentation/devicetree/bindings -name socfpga-\*.txt
./Documentation/devicetree/bindings/net/socfpga-dwmac.txt
./Documentation/devicetree/bindings/edac/socfpga-eccmgr.txt
./Documentation/devicetree/bindings/arm/altera/socfpga-sdram-edac.txt
./Documentation/devicetree/bindings/arm/altera/socfpga-system.txt

Currently, bindings described in these .txt files are not covered by
bindings check. Is it supposed to be like that, or is this just
something "historical"?

I would appreciate to take the opportunity to learn more about
bindings and bindings check, and may try to convert the files to
.yaml. Is this ok or do you have plans with those files?

If noone speaks up, I'll put my name under the maintainers in the
.yaml. Let's see what happens (I hope it's ok, due to the high demand
in cyclone5 these days...).

Best regards,
Lothar