Re: [PATCH 2/2] pinctrl: qcom: Add sm8750 pinctrl driver
From: Linus Walleij
Date: Fri Oct 25 2024 - 04:43:37 EST
On Wed, Oct 23, 2024 at 8:18 PM Melody Olvera <quic_molvera@xxxxxxxxxxx> wrote:
> On 10/22/2024 8:27 PM, Bjorn Andersson wrote:
> > On Mon, Oct 21, 2024 at 04:04:14PM GMT, Melody Olvera wrote:
> > [..]
> >> +static const int sm8750_reserved_gpios[] = {
> >> + 36, 37, 38, 39, 74, -1
> > Any particular reason why these are not gpio-reserved-ranges in
> > DeviceTree?
> >
>
> Not particularly; I wasn't sure whether or not to include in the initial
> dt patch.
> Will add.
Can we also write (as a comment in the device tree) *why* they
are reserved? Such as "used by BIOS/ACPI/secure world"?
Just a minor nit but it's very helpful for newcomers reading the
DTS.
Yours,
Linus Walleij