Re: [PATCH 01/26] mm: asi: Make some utility functions noinstr compatible

From: Borislav Petkov
Date: Fri Oct 25 2024 - 07:42:05 EST


On Fri, Jul 12, 2024 at 05:00:19PM +0000, Brendan Jackman wrote:
> +/*
> + * Can be used for functions which themselves are not strictly noinstr, but
> + * may be called from noinstr code.
> + */
> +#define inline_or_noinstr \

Hmm, this is confusing. So is it noinstr or is it getting inlined?

I'd expect you either always inline the small functions - as you do for some
aleady - or mark the others noinstr. But not something in between.

Why this?

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette