Re: [PATCH v4 1/8] x86/sev: Prepare for using the RMPREAD instruction to access the RMP

[Borislav Petkov]

On Wed, Oct 23, 2024 at 01:41:55PM -0500, Tom Lendacky wrote:
> +/*
> + * The RMP entry format as returned by the RMPREAD instruction.
> + */
> +struct rmpread {

Hmm, I'm not sure this is better. "rmread" is an instruction but then you have
a struct called this way too. Strange. :-\

I think you almost had it already with a little more explanations:

https://lore.kernel.org/r/20241018111043.GAZxJCM8DK-wEjDJZR@fat_crate.local

The convention being that the _raw entry is what's in the actual table and
rmpentry is what RMPREAD returns. I think this is waaay more natural.

Hmmm.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette