Re: [PATCH v10 0/4] perf arm-spe: Allow synthesizing of branch instructions

From: James Clark
Date: Fri Oct 25 2024 - 09:08:21 EST




On 25/10/2024 11:52 am, Graham Woodward wrote:
Currently the --itrace=b will only show branch-misses but this change
allows perf to synthesize branches as well.

The change also incorporates the ability to display the target
addresses when specifying the addr field if the instruction is a branch.

Graham Woodward (4):
perf arm-spe: Set sample.addr to target address for instruction sample
perf arm-spe: Use ARM_SPE_OP_BRANCH_ERET when synthesizing branches
perf arm-spe: Correctly set sample flags
perf arm-spe: Update --itrace help text

tools/perf/Documentation/itrace.txt | 2 +-
tools/perf/Documentation/perf-arm-spe.txt | 2 +-
tools/perf/builtin-script.c | 1 +
tools/perf/util/arm-spe.c | 31 ++++++++++++++++++-----
tools/perf/util/auxtrace.h | 3 +--
tools/perf/util/event.h | 1 +
6 files changed, 29 insertions(+), 11 deletions(-)


Hi Graham,

I think this is V1? Also it looks like the base doesn't include a few of the new SPE changes and it doesn't apply cleanly. Make sure it's based of the latest (46610ba41ef1)

With that LGTM:

Reviewed-by: James Clark <james.clark@xxxxxxxxxx>