Re: [PATCH] mfd: intel_soc_pmic_crc: Add support for non ACPI instantiated i2c_client

From: Andy Shevchenko
Date: Fri Oct 25 2024 - 09:28:02 EST


On Fri, Oct 25, 2024 at 10:37:12AM +0200, Hans de Goede wrote:
> On some x86 Bay Trail tablets which shipped with Android as factory OS,
> the DSDT is so broken that the PMIC needs to be manually instantiated by
> the special x86-android-tablets.ko "fixup" driver for cases like this.
>
> Add an i2c_device_id table so that the driver can match on manually
> instantiated i2c_client-s (which lack an ACPI fwnode to match on).

...

> +static const struct i2c_device_id crystal_cove_i2c_match[] = {
> + { "intel-crystal-cove" },

Why this can't be "crystal_cove_i2c"?

> + { }
> +};

...

> .driver = {
> .name = "crystal_cove_i2c",
> .pm = pm_sleep_ptr(&crystal_cove_pm_ops),
> .acpi_match_table = crystal_cove_acpi_match,
> },

--
With Best Regards,
Andy Shevchenko