Re: [PATCH v4 1/8] x86/sev: Prepare for using the RMPREAD instruction to access the RMP

[Tom Lendacky]

On 10/25/24 08:47, Tom Lendacky wrote:
> On 10/25/24 07:09, Borislav Petkov wrote:
>> On Wed, Oct 23, 2024 at 01:41:55PM -0500, Tom Lendacky wrote:
>>> +/*
>>> + * The RMP entry format as returned by the RMPREAD instruction.
>>> + */
>>> +struct rmpread {
>>
>> Hmm, I'm not sure this is better. "rmread" is an instruction but then you have
>> a struct called this way too. Strange. :-\
>>
>> I think you almost had it already with a little more explanations:
>>
>> https://lore.kernel.org/r/20241018111043.GAZxJCM8DK-wEjDJZR@fat_crate.local

And why am I not getting the replies you made to the v2 series but getting
replies to the v3 and v4 series...  very frustrating... can't find them in
quarantine or anywhere, dang email system.

Thanks,
Tom

>>
>> The convention being that the _raw entry is what's in the actual table and
>> rmpentry is what RMPREAD returns. I think this is waaay more natural.
>>
>> Hmmm.
> 
> Just wanted to show you what it looks like. There still is a lot of change
> because of the new argument and using a structure now instead of the
> direct entry.
> 
> I can change back and maybe add some more detail above the struct names if
> that suffices.
> 
> Thanks,
> Tom
> 
>>