Re: [PATCH 1/1] i3c: master: svc: Modify enabled_events bit 7:0 to act as IBI enable counter

From: Miquel Raynal
Date: Fri Oct 25 2024 - 10:10:38 EST


Hi Frank,

Frank.li@xxxxxxx wrote on Fri, 25 Oct 2024 10:00:50 -0400:

> On Fri, Oct 25, 2024 at 09:53:18AM +0200, Miquel Raynal wrote:
> > Hi Frank,
> >
> > Frank.Li@xxxxxxx wrote on Thu, 24 Oct 2024 16:38:55 -0400:
> >
> > > Fix issue where disabling IBI on one device disables the entire IBI
> > > interrupt. Modify bit 7:0 of enabled_events to serve as an IBI enable
> >
> > Is this bitfield arbitrary?
> >
> > Is there a rationale behind it?
>
> Max devices number under a I3C bus is 128 because dynamic address is 7 bit.
> So 8 bits for it should be enough.
>
> Bit31 as hotjoin, Bit30 reserved as control switch request.

Makes sense.

Thanks,
Miquèl