Re: [PATCH] misc: Silence warnings when building the LAN966x device tree overlay

[Philipp Zabel]

On Fr, 2024-10-25 at 10:40 -0500, Rob Herring wrote:
> On Fri, Oct 25, 2024 at 9:54 AM Philipp Zabel <p.zabel@xxxxxxxxxxxxxx> wrote:
> > 
> > Silence the following warnings when building the LAN966x device tree
> > overlay:
> > 
> > drivers/misc/lan966x_pci.dtso:34.23-40.7: Warning (interrupts_property): /fragment@0/__overlay__/pci-ep-bus@0/oic@e00c0120: Missing interrupt-parent
> 
> > drivers/misc/lan966x_pci.dtso:42.22-46.7: Warning (simple_bus_reg): /fragment@0/__overlay__/pci-ep-bus@0/cpu_clk: missing or empty reg/ranges property
> > drivers/misc/lan966x_pci.dtso:48.22-52.7: Warning (simple_bus_reg): /fragment@0/__overlay__/pci-ep-bus@0/ddr_clk: missing or empty reg/ranges property
> > drivers/misc/lan966x_pci.dtso:54.22-58.7: Warning (simple_bus_reg): /fragment@0/__overlay__/pci-ep-bus@0/sys_clk: missing or empty reg/ranges property
> 
> These nodes should be moved out of the simple-bus.

Ah, thank you. Hervé, can you send a follow-up to fix these?

> > drivers/misc/lan966x_pci.dtso:18.15-165.5: Warning (avoid_unnecessary_addr_size): /fragment@0/__overlay__: unnecessary #address-cells/#size-cells without "ranges", "dma-ranges" or child "reg" property
> 
> For this one,  dtc should be fixed to also look for child "ranges" property.

Gave it a shot:

https://lore.kernel.org/devicetree-compiler/20241025161307.3629901-1-p.zabel@xxxxxxxxxxxxxx/T/#u


> Aren't these other ones all W=1 warnings?

My bad, you are right. I'll drop them from this patch.

regards
Philipp