Re: [PATCH v2] bcachefs: fix null-ptr-deref in have_stripes()
From: Kent Overstreet
Date: Fri Oct 25 2024 - 13:30:35 EST
On Sat, Oct 26, 2024 at 01:05:50AM +0800, Alan Huang wrote:
> On Oct 26, 2024, at 00:54, Kent Overstreet <kent.overstreet@xxxxxxxxx> wrote:
> >
> > On Fri, Oct 25, 2024 at 08:56:18PM +0900, Jeongjun Park wrote:
> >> c->btree_roots_known[i].b can be NULL. In this case, a NULL pointer dereference
> >> occurs, so you need to add code to check the variable.
> >>
> >> Reported-by: syzbot+b468b9fef56949c3b528@xxxxxxxxxxxxxxxxxxxxxxxxx
> >> Fixes: 7773df19c35f ("bcachefs: metadata version bucket_stripe_sectors")
> >> Signed-off-by: Jeongjun Park <aha310510@xxxxxxxxx>
> >
> > This looks identical to the v1? It's already in my testing branch
>
> This version fix the “Fixes" tag, the original one is:
>
> "Fixes: ("bcachefs: metadata version bucket_stripe_sectors”)"
thanks