Re: [PATCH v2 4/5] arm64: dts: qcom: move common parts for qcs8300-ride variants into a .dtsi

From: Konrad Dybcio
Date: Fri Oct 25 2024 - 13:55:51 EST


On 17.10.2024 12:27 PM, YijieYang wrote:
> From: Yijie Yang <quic_yijiyang@xxxxxxxxxxx>
>
> In order to support multiple revisions of the qcs8300-ride board, create
> a .dtsi containing the common parts and split out the ethernet bits into
> the actual board file as they will change in revision 2.
>
> Signed-off-by: Yijie Yang <quic_yijiyang@xxxxxxxxxxx>
> ---

[...]

> chosen {
> - stdout-path = "serial0:115200n8";
> + stdout-path = "serial0: 115200n8";
> };

This looks unintended

The rest looks good, except I think you forgot to drop /dts-v1/
from the dtsi

Konrad