Re: [PATCH v2 2/2] soc: qcom: llcc: add support for SAR2130P and SAR1130P

[Konrad Dybcio]

On 25.10.2024 5:22 PM, Dmitry Baryshkov wrote:
> Implement necessary support for the LLCC control on the SAR1130P and
> SAR2130P platforms. These two platforms use different ATTR1_MAX_CAP
> shift and also require manual override for num_banks.
> 
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
> ---

I'm not going to verify each and every value, but this generally
looks good

[...]

> +		.max_cap_shift	= 0x0e,

This should be a decimal 14 (as it's denoting the bit position)

Konrad