Re: [PATCH v3 3/5] mm: madvise: implement lightweight guard page mechanism
From: Andrew Morton
Date: Fri Oct 25 2024 - 20:11:43 EST
On Thu, 24 Oct 2024 08:25:46 +0100 Lorenzo Stoakes <lorenzo.stoakes@xxxxxxxxxx> wrote:
> I actually do plan to extend this work to support shmem and file-backed
> mappings in the future as a revision to this work.
Useful, thanks. I pasted this in.
> >
> > (generally, it would be nice to include the proposed manpage update at
> > this time, so people can review it while the code change is fresh in
> > their minds)
>
> It'd be nice to have the man pages live somewhere within the kernel so we
> can do this as part of the patch change as things evolve during review, but
> obviously moving things about like that is out of scope for this discussion
> :)
Yes, that would be good. At present the linkage is so poor that things
could get lost.
I guess one thing we could do is to include the proposed manpage update
within the changelogs. That way it's stored somewhere and gets reviewed
alongside the patches themselves.
> I do explicitly intend to send a manpage update once this series lands
> however.
That's late, IMO. Sometimes reviewing manpage updates leads people to
ask "hey. what about X" or "hey, that's wrong". Michael Kerrisk was
good at finding such holes, back in the day.