Re: [PATCH] goldfish: Fix unused const variable 'goldfish_pipe_acpi_match'

[Zeng Heng]

On 2024/10/25 22:27, Uwe Kleine-König wrote:
> Hello,
>
> [Cc += Andy]

I would loop in the next version.


> On Fri, Oct 25, 2024 at 03:41:29PM +0800, Zeng Heng wrote:
> > Fix the following compilation warning:
> >
> > drivers/platform/goldfish/goldfish_pipe.c:925:36: warning:
> > ‘goldfish_pipe_acpi_match’ defined but not used
> > [-Wunused-const-variable=]
> >    925 | static const struct acpi_device_id goldfish_pipe_acpi_match[] = {
> >
> > Only define the const variable when the CONFIG_ACPI is enabled.
> Note you also need CONFIG_MODULE=n to reproduce.
>
> > Fixes: d62f324b0ac8 ("goldfish: Enable ACPI-based enumeration for android pipe")
> > Signed-off-by: Zeng Heng <zengheng4@xxxxxxxxxx>
> > ---
> >   drivers/platform/goldfish/goldfish_pipe.c | 2 ++
> >   1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/platform/goldfish/goldfish_pipe.c b/drivers/platform/goldfish/goldfish_pipe.c
> > index c2aab0cfab33..aeabacba3760 100644
> > --- a/drivers/platform/goldfish/goldfish_pipe.c
> > +++ b/drivers/platform/goldfish/goldfish_pipe.c
> > @@ -922,11 +922,13 @@ static void goldfish_pipe_remove(struct platform_device *pdev)
> >   	goldfish_pipe_device_deinit(pdev, dev);
> >   }
> >   
> > +#ifdef CONFIG_ACPI
> >   static const struct acpi_device_id goldfish_pipe_acpi_match[] = {
> >   	{ "GFSH0003", 0 },
> >   	{ },
> >   };
> >   MODULE_DEVICE_TABLE(acpi, goldfish_pipe_acpi_match);
> > +#endif
> >   
> >   static const struct of_device_id goldfish_pipe_of_match[] = {
> >   	{ .compatible = "google,android-pipe", },
> Looking at changes like
> https://lore.kernel.org/all/20241024130424.3818291-11-andriy.shevchenko@xxxxxxxxxxxxxxx/
> I suggest to drop the use of ACPI_PTR() instead.

Right, got it.


Best regards,

Zeng Heng